Skip to content

Conversation

@laurator
Copy link
Contributor

Description

Added test file for EEG. Improvements of modularity to avoid repeating the code. As the data for the EEG example is not public, GitHub Actions will ignore this specific test.

Changes

  • Added test file for the EEG example. It resembles the test for LFP, but now for the EEG example.
  • Configuration of GitHub Actions will ignore this test for EEG.
  • Common functions between tests are now in a separate and common file for all tests.
  • Improvements in workflows cache

Test

  • To test locally, pip install -r requirements.txt and then in the /ncpi folder, pip install .
  • Specify the data path for the restricted data of the EEG example. If you already have downloaded the zenodo simulation files, indicate its path too to avoid downloading them again.
  • Run pytest -v. It will find and execute both tests (EEG and LFP).
  • python ./test_EEG.py is also possible. Uncomment the last 5 lines to test it as a script.

Copy link
Contributor

@AlejandroOrozcoValero AlejandroOrozcoValero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the instructions and when I run pytest -v it returns the following error
Captura desde 2025-10-31 13-18-46

@laurator
Copy link
Contributor Author

laurator commented Nov 3, 2025

And have you run pip install .?

@AlejandroOrozcoValero
Copy link
Contributor

It still gives an error when loading data:

Captura desde 2025-11-03 12-00-05

Copy link
Contributor

@AlejandroOrozcoValero AlejandroOrozcoValero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the failing tests. All tests now pass successfully.

@pablomc88 pablomc88 merged commit 9221688 into main Nov 5, 2025
2 checks passed
@pablomc88 pablomc88 deleted the ncpi-tests branch November 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants