forked from puppetlabs/puppet
-
Notifications
You must be signed in to change notification settings - Fork 0
Create stpst 11 version with Trixie support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rfpronk
wants to merge
25
commits into
main
Choose a base branch
from
stpst11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6191fb8
Patch files for modern Ruby and Debian compatibility
rfpronk 1257701
Bump version
rfpronk f0b70eb
Update racc build gem to ruby 2.7 compatible version
rfpronk 1817cad
Use fixed gem versions and update some
rfpronk 1680b20
Allow longer version numbers (following gem guidelines)
rfpronk d36124e
Bump version to 3.8.7.stpst.1
rfpronk 0735c94
Apply patches for Stretch and Ruby coming from omnibus package
rfpronk 8e374cb
Specify gem dependencies for newer Rubies
rfpronk 6b0643d
Add gems needed for rspec
rfpronk 6fdc0c8
Commit update to 3.8.7.stpst.2 in lib/puppet/version.rb
rfpronk 66d45a3
Update gems and fix rspec tests
rfpronk e6e989b
Hard define version and make it stpst.3
rfpronk bc607f0
Update facter requirement
rfpronk e405747
Use custom build facter
rfpronk 6560b50
Bump to stpst.5
rfpronk 6a8d8ec
Fix installing gems on Bullseye
rfpronk 6085f85
Use hiera-1.3.4.stpst.1 in stpst.7 version
rfpronk 45c7fcd
Set systemd as default provider for Bookworm
rfpronk aafd74c
bump version to stpst.8
rfpronk 1073d2b
bump version
rfpronk b0759f9
downgrade syck
rfpronk 032017e
bump version to stpst.10
rfpronk 6e54d02
Use systemd on trixie
rfpronk 47226b5
bump version
rfpronk 574969b
correct stpst.11 versioning
rfpronk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.8.7.stpst.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,13 +45,13 @@ | |
| # if you apply this to third party faces you might well be disappointed. | ||
| context "licensing of Puppet Labs face '#{face_name}'" do | ||
| subject { Puppet::Face[face_name, :current] } | ||
| its :license do should =~ /Apache\s*2/ end | ||
| its :copyright do should =~ /Puppet Labs/ end | ||
| it :license do should =~ /Apache\s*2/ end | ||
| it :copyright do should =~ /Puppet Labs/ end | ||
|
|
||
| # REVISIT: This is less that ideal, I think, but right now I am more | ||
| # comfortable watching us ship with some copyright than without any; we | ||
| # can redress that when it becomes appropriate. --daniel 2011-04-27 | ||
| its :copyright do should =~ /20\d{2}/ end | ||
| it :copyright do should =~ /20\d{2}/ end | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weird that the syntax changed! The possessive |
||
| end | ||
| end | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not important enough to request it as a change, but I wanted to flag it since it's a tiiiiny example of something I see a lot in stpst code (not you specifically, just in general, even by me when I miss it)
When a conditional has a common component, yanking it out sets you up for success. Because if that thing grows, it becomes more duplication to maintain. Or if it changes in one it might be forgotten in the other.
Again, this is like 10 characters so it doesn't matter here at all, I'm not that pedantic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah I agree, but I didn't touch that part of the code 😄 That's made by puppetlabs
3.8.7.stpst.10...nedap:puppet-gem:stpst11 is what I changed here