Make the release smoke retry loop actually retry - #2
Merged
Conversation
…y retry 0.2.0 published correctly to both registries and the smoke job still failed, for a reason that had nothing to do with the packages. PyPI had not propagated `tx402==0.2.0` when attempt 1 ran — exactly the race the retry loop exists for. But `uv venv` had already created `.venv` before `uv pip install` failed, so attempts 2 through 5 died at `uv venv` with "a virtual environment already exists", and the `&&` chain short-circuited before the install was ever retried. A loop written to survive propagation lag could not survive its own first failure. `uv venv --clear` recreates the environment each round, so a retry is actually a retry. Both loops also ran off the end when every attempt failed, leaving the next command to report the problem. That is why the log's headline was `Failed to spawn: tx402 — No such file or directory` rather than "the package never appeared", which is what actually happened. Each loop now fails explicitly and names the registry and version. Verified by reproducing it: a second plain `uv venv` reports "already exists", and `uv venv --clear` succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.2.0 published correctly to both registries and the smoke job still went red, for a reason that had nothing to do with the packages.
What happened
PyPI had not propagated
tx402==0.2.0when attempt 1 ran — exactly the race the retry loop exists for. Butuv venvhad already created.venvbeforeuv pip installfailed, so attempts 2 through 5 died atuv venv:The
&&chain short-circuited there, so the install was never retried even once. A loop written to survive propagation lag could not survive its own first failure.The fix
uv venv --clearrecreates the environment each round, so a retry is actually a retry.Both loops also ran off the end when every attempt failed, leaving the next command to report the problem. That is why the log's headline was
Failed to spawn: tx402 — No such file or directoryrather than "the package never appeared", which is what actually happened. Each loop now fails explicitly and names the registry and the version.Verification
Reproduced directly:
uv venvalready exists— the failureuv venv --clearuv venv && uv pip install tx402==0.2.0todayThe 0.2.0 artifacts themselves were verified by hand from the registries: all 12 entry points load, both CLIs report
0.2.0, and npm carries a SLSA provenance v1 attestation.tx402/durable-objectandtx402/gateway/workerimportcloudflare:workersand so load only under the Workers runtime — by design, and confirmed against the published tarball with that specifier stubbed.CI-only change. No package, source or documentation is touched.