Announce only the remaining bytes of an upload IO - #86
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use an upload stream's remaining byte count when it exposes its current position, and clamp a position beyond EOF to zero. Do not rewind or close caller-owned IO.
Reproduction and evidence
Standalone local reproduction:
The actual state-machine reproduction previously announced six bytes then sent only
def. It now announces/sends three. Combined release checks cover StringIO and File, empty sources, offsets past EOF and multiple chunk sizes; local scp interoperability also passes.Compatibility / breaking changes
No public signature or dependency change. Progress totals for partially consumed streams now describe the bytes actually transferred. Streams without pos retain their existing size behavior. Concurrent source growth/truncation is not addressed.
Verification and limits