Reject invalid upload chunk sizes before opening a channel - #87
Open
OskarEichler wants to merge 1 commit into
Open
Reject invalid upload chunk sizes before opening a channel#87OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject zero, negative and non-Integer upload chunk sizes before opening an SSH channel. Preserve the existing nil/false default behavior.
Reproduction and evidence
Standalone local reproduction:
Zero-sized reads repeatedly produce an empty String and never reach EOF. Focused/model checks reject 0, negative integers, floats, strings and arbitrary objects before channel creation, and accept positive integers and the existing defaults.
Compatibility / breaking changes
Intentional validation change: previously coerced non-Integer values (for example 1.5) now raise ArgumentError. Zero/negative invalid values fail earlier instead of hanging/failing after channel setup. Positive Integer behavior is unchanged.
Verification and limits