Pass SCP URI connection settings through the SSH options hash - #90
Open
OskarEichler wants to merge 1 commit into
Open
Pass SCP URI connection settings through the SSH options hash#90OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Put URI-derived port/password defaults in the nested
:sshhash consumed by Net::SCP.download!, while preserving explicit SSH options and their precedence.Reproduction and evidence
The existing adapter passes URI port/password at the outer SCP-options level, but the class download! method only forwards options.delete(:ssh) to Net::SSH.start. A captured call for
scp://user:example@host:2222/filepreviously lacked these values in :ssh; it now includes them. Frozen options and nested hashes remain unchanged. Explicit ssh: {port: 3333, password: 'override'} still wins over URI defaults.Compatibility / breaking changes
URI port/password values previously ignored by this adapter now take effect as defaults. Explicit nested SSH options retain precedence; an absent URI password does not clear a supplied password. Percent-decoding is proposed separately. No secrets or real authentication were used in verification.
Verification and limits