Adapt OpenURI progress and content length callbacks to SCP - #91
Open
OskarEichler wants to merge 1 commit into
Open
Adapt OpenURI progress and content length callbacks to SCP#91OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapt SCP's four-argument progress callback to OpenURI's one-argument byte count, and invoke content_length_proc once even for empty files.
Reproduction and evidence
The adapter previously forwarded a strict OpenURI
->(bytes) { ... }directly to SCP. SCP calls it with channel, filename, received and total, raisingArgumentError: wrong number of arguments (given 4, expected 1). The focused reproduction now passes. Combined models verify empty, one-byte, binary and 20,000-byte transfers, first/final progress and exactly one content-length callback. The extra empty-file progress event does not duplicate content length.Compatibility / breaking changes
Intentional callback correction: callers that relied on the undocumented four-argument SCP signature through OpenURI must instead use OpenURI's byte-count signature or the direct SCP API. content_length_proc, previously ignored, is now honored. Direct Net::SCP progress callbacks are unchanged.
Verification and limits