Refresh parsed SCP options when the URI query changes - #92
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle valueless query entries and empty separators without crashing, and refresh parsed options after query changes while retaining the same options hash when the query is unchanged.
Reproduction and evidence
Standalone local reproduction:
500 model variations cover integer/string/list values, valueless entries, redundant separators, query replacement/removal and mutations to the exposed options hash while the query remains unchanged.
Compatibility / breaking changes
A valueless option follows the existing empty-value representation ([]); numeric/list conversion rules are retained. After a query change, options now reflect that query instead of stale cached values. This does not start applying URI query options to SSH connections or alter percent-decoding rules.
Verification and limits