Stream SCP downloads into the OpenURI buffer - #93
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write SCP chunks directly into OpenURI's existing buffer so it can spill to a temporary file, instead of first accumulating the complete download in an extra StringIO.
Reproduction and evidence
A bounded local simulation transfers 1,024 chunks of 16 KiB (16 MiB), verifies the resulting byte count and uses
/usr/bin/time -lin three fresh Ruby processes per implementation. Median maximum resident size: 70,123,520 → 33,603,584 bytes. Median transfer-buffer time: 0.013746s → 0.010415s. Both produce a Tempfile-backed OpenURI result. These measurements isolate buffering; they are not SSH/network throughput measurements. Combined binary/empty/20,000-byte models and local scp-backed URI integration pass.Compatibility / breaking changes
The OpenURI result and rewind behavior stay unchanged. The private adapter now passes a write-capable destination to Net::SCP.download! rather than requesting a complete String return. Custom monkey patches of that call must accept an IO destination. OpenURI remains responsible for its own memory-to-tempfile threshold and result lifecycle.
Verification and limits