Skip to content

Handle Pathname in download/upload - #153

Open
til wants to merge 1 commit into
net-ssh:masterfrom
til:handle-pathname-based-on-class
Open

Handle Pathname in download/upload#153
til wants to merge 1 commit into
net-ssh:masterfrom
til:handle-pathname-based-on-class

Conversation

@til

@til til commented Mar 25, 2024

Copy link
Copy Markdown

This implements the suggested solution 2.) from #102 for handling Pathname instances in net-sftp.

Co-authored-by: Tilmann Singer <tils@tils.net>
@OskarEichler

Copy link
Copy Markdown

I verified the current PR head and found a direct-load regression: the transfer operation files now reference Pathname, but neither file requires it, so loading either operation directly can raise NameError. A minimal follow-up is available at OskarEichler@9cd2519 and can be cherry-picked. With that fixup, the focused attribute checks (3 runs / 24 assertions), v5 base checks (194 / 374), and full suite (435 / 1,199) pass apart from the pre-existing Ruby 4 StartTest keyword expectation failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants