Copy attribute input before defaults and cached values mutate it - #166
Open
OskarEichler wants to merge 1 commit into
Open
Copy attribute input before defaults and cached values mutate it#166OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Own a shallow copy of the constructor hash and set the v4 default type through the attribute writer.
Reproduction
Net::SFTP::Protocol::V04::Attributes.new({size: 5}.freeze)currently raises FrozenError while inserting:type. Two instances made from the same mutable hash also share scalar updates. Fixed accepts frozen input and isolates instance updates.Verification
Breaking changes and limitations
Intentional compatibility change: later mutations of the original constructor hash no longer update an Attributes instance, and instance writes no longer modify that hash. The public
attributeshash remains mutable. The copy is shallow; nested collections retain their existing ownership.No repository tests were added or modified under the contribution's no-new-tests constraint; focused repro/model drivers ran outside the repository. An external verification Gemfile supplies compatible test tools and RDoc without changing upstream tooling. Actual older Ruby/JRuby/Windows compatibility and upstream CI have not been verified. No production or SSH connections, version bumps, release-tool changes or unrelated modernization are included. Git builds are not signed by the upstream gem release key.