Complete subsecond fields for mixed-precision attribute packets - #168
Open
OskarEichler wants to merge 1 commit into
Open
Complete subsecond fields for mixed-precision attribute packets#168OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When any timestamp requests subsecond encoding, provide zero nanoseconds for the other present whole-second timestamps, including v6 ctime.
Reproduction
V04::Attributes.new(atime: 100, atime_nseconds: 123, mtime: 200).to_sraises TypeError on baseline because the shared flag requires an mtime nanosecond field but its value is nil. Fixed serializes mtime nanoseconds as zero. The same issue affects v6.Verification
Breaking changes and limitations
No signature change. Mixed-precision inputs that failed now serialize; missing nanosecond values for present timestamps become zero during serialization. Whole-second-only packets remain without the subsecond flag. Nanoseconds without their corresponding seconds and other invalid input validation are not broadened. No native v4/v6 server was available; these are packet-level checks.
No repository tests were added or modified under the contribution's no-new-tests constraint; focused repro/model drivers ran outside the repository. An external verification Gemfile supplies compatible test tools and RDoc without changing upstream tooling. Actual older Ruby/JRuby/Windows compatibility and upstream CI have not been verified. No production or SSH connections, version bumps, release-tool changes or unrelated modernization are included. Git builds are not signed by the upstream gem release key.