Skip subdirectory listings for shallow glob patterns - #173
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid descending when a String pattern has no path separator: File::FNM_PATHNAME prevents it matching descendants. Patterns containing separators retain their existing traversal; custom string-like objects retain the old path.
Reproduction and evidence
With a root containing
file.rband a directory whose listing fails,glob(root, "*.rb")currently opens the child and raises even though it cannot match any descendant. Fixed returns file.rb after only the root listing. This addresses the traversal concern in #61 without duplicating its installed root-path fix.Verification
*.binand preserved recursive**/*.rbresults.Breaking changes and limitations
Intentional observable change: shallow patterns no longer perform irrelevant child requests or raise errors from those requests. Returned matches stay unchanged. Prefix pruning for patterns containing slashes, nested dot-entry policy and symlink traversal are not changed.
No repository tests added or modified under the task's no-new-tests constraint; focused scripts ran outside the repository. An external verification Gemfile supplies test tools/RDoc without changing upstream tooling. Older Ruby/JRuby/Windows and upstream CI have not been verified. No production/SSH connections, unrelated upgrades, release changes or signature-equivalence claim.