Skip to content

release 馃殮 - #156

Merged
leoparente merged 10 commits into
releasefrom
develop
Jul 28, 2025
Merged

release 馃殮 #156
leoparente merged 10 commits into
releasefrom
develop

Conversation

@leoparente

Copy link
Copy Markdown
Contributor

This pull request introduces several enhancements and refactors across multiple components of the codebase. The key changes include the addition of a semantic release workflow, support for a "dry-run" mode in discovery backends, and improvements to the Vault test infrastructure. These changes aim to improve CI/CD capabilities, enhance configurability, and modernize testing.

CI/CD Enhancements:

  • Added a new GitHub Actions workflow (.github/workflows/pr-semantic-release.yaml) to perform a semantic release dry-run for pull requests targeting the release branch. This workflow analyzes commit messages, simulates a release, and comments the results on the pull request.

Discovery Backend Improvements:

  • Introduced dry_run and dry_run_output_dir configuration options for both networkDiscoveryBackend and snmpDiscoveryBackend. These options allow the backends to operate in a simulation mode, bypassing live API interactions. (agent/backend/networkdiscovery/network_discovery.go: [1] [2] [3]; agent/backend/snmpdiscovery/snmp_discovery.go: [4] [5] [6]
  • Added unit tests for the "dry-run" mode in both networkDiscoveryBackend and snmpDiscoveryBackend to validate behavior and ensure proper argument handling. (network_discovery_test.go: [1]; snmp_discovery_test.go: [2]

Documentation Updates:

  • Updated the README.md to include the new dry_run and dry_run_output_dir configuration options under the common subsection of the backends configuration.

Vault Test Refactor:

  • Replaced the in-memory Vault test setup with a Docker-based testcluster implementation for improved reliability and consistency in testing. This refactor impacts multiple test cases and introduces a new createTestVault helper function. (vault_test.go: [1] [2] [3] [4]; vault_auth_test.go: [5]

@leoparente leoparente self-assigned this Jul 28, 2025
@github-actions

Copy link
Copy Markdown

Semantic Release Dry Run Results 馃攳

鈩癸笍 No new release would be published

Commit Messages:

doc: fixes typo in config samples (#141)
docs: updates docs for snmp timeout config values (#142)
feat: add dry run mode support to network and snmp discovery (#140)
chore: bump vault version to 1.20 (#144)
docs: adds documentation for snmp env var config (#146)
chore: update device discovery docs (#145)
docs: corrects protocol versions (#147)
chore: adds comment to PRs with release version (#136)
docs: snmp discovery example syntax fix (#152)

No semantic changes detected that would trigger a release.

@github-actions

github-actions Bot commented Jul 28, 2025

Copy link
Copy Markdown

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
馃煝 PASS 0.17s github.com/netboxlabs/orb-agent/agent 0.0% 0 0 0
馃煝 PASS 0.17s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
馃煝 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 76.0% 3 0 0
馃煝 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/mocks 0.0% 0 0 0
馃煝 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 75.8% 3 0 0
馃煝 PASS 4.02s github.com/netboxlabs/orb-agent/agent/backend/otel 76.4% 2 0 0
馃煝 PASS 3.02s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 65.6% 2 0 0
馃煝 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/snmpdiscovery 75.8% 3 0 0
馃煝 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/worker 76.0% 3 0 0
馃煝 PASS 1.01s github.com/netboxlabs/orb-agent/agent/config 100.0% 6 0 0
馃煝 PASS 1.04s github.com/netboxlabs/orb-agent/agent/configmgr 49.2% 9 0 0
馃煝 PASS 1.01s github.com/netboxlabs/orb-agent/agent/policies 100.0% 15 0 0
馃煝 PASS 1.02s github.com/netboxlabs/orb-agent/agent/policymgr 70.3% 10 0 0
馃煝 PASS 27.35s github.com/netboxlabs/orb-agent/agent/secretsmgr 45.7% 45 0 0
馃煝 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 58.0%

@leoparente

Copy link
Copy Markdown
Contributor Author

ic changes detected that would trigger a releas

@jajeffries this does not seem right

Comment thread .github/workflows/pr-semantic-release.yaml Outdated
@github-actions

Copy link
Copy Markdown

Semantic Release Dry Run Results 馃攳

鈩癸笍 No new release would be published

Commit Messages:

doc: fixes typo in config samples (#141)
docs: updates docs for snmp timeout config values (#142)
feat: add dry run mode support to network and snmp discovery (#140)
chore: bump vault version to 1.20 (#144)
docs: adds documentation for snmp env var config (#146)
chore: update device discovery docs (#145)
docs: corrects protocol versions (#147)
chore: adds comment to PRs with release version (#136)
docs: snmp discovery example syntax fix (#152)
chore: correct releaserc branch for PR semantic release check (#157)

No semantic changes detected that would trigger a release.

@leoparente
leoparente merged commit 8db98de into release Jul 28, 2025
8 checks passed
@github-actions

Copy link
Copy Markdown

馃帀 This PR is included in version 2.3.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants