Skip to content

feat: mention detected framework when initializing build settings #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
serhalp wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Draft

feat: mention detected framework when initializing build settings #7828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/utils/init/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ export const getBuildSettings = async ({
log()
}

const frameworkName = setting.framework?.name
if (frameworkName) {
log(`We detected that you're using ${formatTitle(frameworkName)}. Below are recommended build settings.`)
log('For each setting, press Enter to accept the default or provide your own value.')
log()
}

const { baseDir, buildCmd, buildDir } = await inquirer.prompt<{
baseDir?: string | undefined
buildCmd: string
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/commands/init/init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ describe.concurrent('commands/init', () => {

handleQuestions(childProcess, initQuestions)

await childProcess
const { stdout } = await childProcess

t.expect(stdout).toContain("We detected that you're using Next.js. Below are recommended build settings.")

await assertNetlifyToml(t, builder.directory, { command, functions: defaultFunctionsDirectory, publish })
})
Expand Down
Loading