-
Notifications
You must be signed in to change notification settings - Fork 784
Update data models #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update data models #2244
Conversation
| | `CHASSIS_ID` | often represents CDP or LLDP neighbor chassis ID | | ||
| | `DESCRIPTION` | often used for port or interface descriptions | | ||
| | `GATEWAY` | gateway address for a subnet | | ||
| | `INNER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing trailing period from INNER_VLAN
| | `INNER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | | |
| | `INNER_VLAN` | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | |
| | `NETMASK` | for IPv4 dotted quad masks | | ||
| | `NETMASKS` | list of IPv4 dotted quad masks | | ||
| | `NETWORK` | for network numbers or subnet address (without the mask or prefix/slash notation); in place of ROUTE | | ||
| | `OUTER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing trailing period from OUTER_VLAN
| | `OUTER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | | |
| | `OUTER_VLAN` | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG | |
| | `ACCESS_GROUP_IN` | access group for IPv4 addresses, inbound | | ||
| | `ACCESS_GROUP_OUT` | access group for IPv4 addresses, outbound | | ||
| | `ACCESS_GROUP_V6_IN` | access group for IPv6 addresses, inbound | | ||
| | `ACCESS_GROUP_V6_OUT` | access group for IPv6 addresses, outbound | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update description to flow/read better.
| | `ACCESS_GROUP_IN` | access group for IPv4 addresses, inbound | | |
| | `ACCESS_GROUP_OUT` | access group for IPv4 addresses, outbound | | |
| | `ACCESS_GROUP_V6_IN` | access group for IPv6 addresses, inbound | | |
| | `ACCESS_GROUP_V6_OUT` | access group for IPv6 addresses, outbound | | |
| | `ACCESS_GROUP_IN` | inbound access group for IPv4 addresses | | |
| | `ACCESS_GROUP_OUT` | outbound access group for IPv4 addresses | | |
| | `ACCESS_GROUP_V6_IN` | inbound access group for IPv6 addresses | | |
| | `ACCESS_GROUP_V6_OUT` | outbound access group for IPv6 addresses | |
|
There are some more detailed descriptions I put in the data model on PR #2241 I have been thinking about opening an issue to discuss a few items rather than discuss it on 2241. For example type checking (is it a 💡 Where capture group name normalization helps the community the most is when working with 2+ platforms for the same command(s)/protocol(s) in the same script, playbook, etc. (This is the reason I started some normalization.) |
Added some new variables from recent PR conversations to the data models. I'm looking to discuss these and have a conversation as to their validity.