Skip to content

Conversation

@matt852
Copy link
Contributor

@matt852 matt852 commented Nov 26, 2025

Added some new variables from recent PR conversations to the data models. I'm looking to discuss these and have a conversation as to their validity.

| `CHASSIS_ID` | often represents CDP or LLDP neighbor chassis ID |
| `DESCRIPTION` | often used for port or interface descriptions |
| `GATEWAY` | gateway address for a subnet |
| `INNER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing trailing period from INNER_VLAN

Suggested change
| `INNER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |
| `INNER_VLAN` | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |

| `NETMASK` | for IPv4 dotted quad masks |
| `NETMASKS` | list of IPv4 dotted quad masks |
| `NETWORK` | for network numbers or subnet address (without the mask or prefix/slash notation); in place of ROUTE |
| `OUTER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing trailing period from OUTER_VLAN

Suggested change
| `OUTER_VLAN`. | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |
| `OUTER_VLAN` | numeric VLAN identifier; used instead of VLAN, VLANID, or TAG |

Comment on lines +25 to +28
| `ACCESS_GROUP_IN` | access group for IPv4 addresses, inbound |
| `ACCESS_GROUP_OUT` | access group for IPv4 addresses, outbound |
| `ACCESS_GROUP_V6_IN` | access group for IPv6 addresses, inbound |
| `ACCESS_GROUP_V6_OUT` | access group for IPv6 addresses, outbound |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update description to flow/read better.

Suggested change
| `ACCESS_GROUP_IN` | access group for IPv4 addresses, inbound |
| `ACCESS_GROUP_OUT` | access group for IPv4 addresses, outbound |
| `ACCESS_GROUP_V6_IN` | access group for IPv6 addresses, inbound |
| `ACCESS_GROUP_V6_OUT` | access group for IPv6 addresses, outbound |
| `ACCESS_GROUP_IN` | inbound access group for IPv4 addresses |
| `ACCESS_GROUP_OUT` | outbound access group for IPv4 addresses |
| `ACCESS_GROUP_V6_IN` | inbound access group for IPv6 addresses |
| `ACCESS_GROUP_V6_OUT` | outbound access group for IPv6 addresses |

@mjbear
Copy link
Collaborator

mjbear commented Nov 27, 2025

There are some more detailed descriptions I put in the data model on PR #2241

I have been thinking about opening an issue to discuss a few items rather than discuss it on 2241.

For example type checking (is it a list or a string) is simple and minimizes capture group sprawl. (I recognize the breaking behavior and there may likely be opposition. And certainly not something I'm immovable on.)

💡 Where capture group name normalization helps the community the most is when working with 2+ platforms for the same command(s)/protocol(s) in the same script, playbook, etc. (This is the reason I started some normalization.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants