Format videos to poseinterface spec. Extract clip function. #39
Merged
Conversation
7 tasks
niksirbi
reviewed
Mar 31, 2026
sfmig
force-pushed
the
video-utils
branch
2 times, most recently
from
747985c to
3ade24a
Compare
niksirbi
requested changes
Apr 20, 2026
Member
niksirbi
left a comment
niksirbi
left a comment
There was a problem hiding this comment.
Thanks @sfmig.
I tried using the new functions in #40. They mostly worked, but I've stumbled on a few issues that need to be addressed before merging (see inline comments). Happy to do another round of review after we resolve these (I skipped the tests in this round).
By the way, if we want the new public functions to appear in the API references, we have to add them manually in api_index.rst (we haven't yet set up the automatic machinery we have in movement).
Member
Author
|
Hi @niksirbi , thanks for the review and apologies for the delay. I believe this is now ready to go, will request a re-review now. |
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
Restore TEST_DATA_DLC_DIR/TEST_DATA_SLEAP_DIR constants, the sub_ses_cam_ids fixture, and the updated CSV source path that were introduced by the annotations_to_coco refactor on main but dropped during the rebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Raise RuntimeError if ffmpeg fails to read encoding info, and widen the return type of _get_codec_pixelformat to dict[str, str | None] to match the upstream VideoEncodingInfo field types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Also fix cross-reference to extract_clip in the benchmark dataset spec by using the fully qualified module path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
What does this PR do?
video_to_poseinterfaceto io module, to convert a video toposeinterfaceformat.cliplabels.jsonfile, given a video inposeinterfaceformat, its full video annotations incliplabels.jsonformat and a range of frames.extract-clipReferences
\
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
Yes, docstrings.
Checklist: