Repository navigation
tooling: Update eslint to v9; update jsdoc; update dependencies - #2206
Open
marcustyphoon wants to merge 17 commits into
Open
marcustyphoon wants to merge 17 commits into
marcustyphoon wants to merge 17 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates eslint to v9, which requires a new configuration file format, as well as updating our other dependencies; notably, web-ext ≥9 also uses eslint 9 internally.
It replaces the built-in jsdoc rules in eslint v8 with eslint-plugin-jsdoc (the recommended config, with some rules turned off to reduce friction). This requires modernizing some jsdoc throughout the extension.
This also updates various dependencies, resolving numerous security warnings.
Supersedes #2205 and #2203. (This could be a stacked PR on #2203, but I would have to remake that PR on a non-fork branch.)