Repository navigation
feat(providers): add Pulsenote - #13487
Open
gpabijan88 wants to merge 1 commit into
Open
gpabijan88 wants to merge 1 commit into
gpabijan88 wants to merge 1 commit into
Conversation
Pulsenote is an email API with EU data residency. Magic links are its main use case, so a built-in provider makes it discoverable where people actually look. Follows the shape of the other HTTP email providers (Resend, Forward Email), with one addition: Pulsenote accepts and renders a message without delivering it when the account has no verified sending domain, so the provider throws in that case. Left unchecked, sign-in would report success while the user waits for a link that was never sent. Documented with JSDoc rather than @todo, per the contributing guide.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@gpabijan88 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Adds Pulsenote as a built-in email provider. It is an email API with EU data residency, and magic links are its primary use case — so the built-in list is where people would look for it.
The implementation follows the existing HTTP email providers (
resend.ts,forwardemail.ts) rather than the Nodemailer one: a singlefetch, no new dependency.One addition worth flagging. Pulsenote sends only from a domain the account has verified. Until one is verified, the API accepts and renders a message but does not deliver it, returning
sandbox: true. Left unchecked,sendVerificationRequestwould resolve, Auth.js would report success, and the user would wait indefinitely for a link that was never sent — with nothing in any log to explain it. The provider throws instead, with an actionable message.🧢 Checklist
Documented with JSDoc in the same file, per the contributing guide, rather than the
@todo Document thisthe neighbouring email providers currently carry. Kept to what an email provider needs — no OAuth boilerplate.No tests: the existing email providers (
resend,forwardemail,postmark,sendgrid) have none, so this follows the established pattern. Happy to add them if you would prefer.Following the contributing guide
packages/core/src/providers/pulsenote.ts, named default exportdocs/public/img/providers/pulsenote.svg.github/ISSUE_TEMPLATE/2_bug_provider.yml, in alphabetical positionprovider-types.tsis generated and gitignored, so it is not committed —pnpm providerspicks the new file up on its own; verified locally.Verification
Built and type-checked inside this monorepo:
pnpm css && pnpm providersfollowed bytsc --noEmit -p packages/core/tsconfig.jsonreports no errors, and the generatedprovider-types.tscontainspulsenote.Disclosure: I maintain Pulsenote. Happy to adjust anything to fit your conventions, or to close this if built-in providers are not being expanded right now.