Repository navigation
fix(providers): fix Bungie provider TypeScript and X-API-Key header - #13490
Open
tahiraltundag wants to merge 1 commit into
Open
tahiraltundag wants to merge 1 commit into
tahiraltundag wants to merge 1 commit into
Conversation
Fixes nextauthjs#6930 - Allow headers option with X-API-Key in Bungie provider options to fix TypeScript error - Convert userinfo from string to object with custom request that sends X-API-Key header - Handle membershipId from tokens to build correct userinfo URL
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@tahiraltundag is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6930
Problem
headers: { "X-API-Key": BUNGIE_API_KEY }but TypeScript typeOAuthUserConfigdoes not allowheaders, causing TS erroruserinfowithout sendingX-API-Keyheader, so Bungie API rejects userinfo request (login fails)Solution
headers?: Record<string, string>userinfofrom string to object with customrequestthat sendsX-API-Keyheader and builds correct URL usingmembership_idfrom tokensTested with
pnpm lint(no errors) andtsccheck.