use a public/private key logic for token generation#7696
Draft
Zoey2936 wants to merge 3 commits into
Draft
Conversation
Zoey2936
commented
Mar 5, 2026
szaimen
added
2. developing
Signed-off-by: Zoey <zoey@z0ey.de>
Zoey2936
commented
Apr 13, 2026
| } | ||
|
|
||
| $timeElapsed = time() - (int) $timestamp; | ||
| if ($timeElapsed > 60 || $timeElapsed < 0) { |
Collaborator
Author
There was a problem hiding this comment.
not sure if this is enough time, if this is changed then apcu_add also needs to be changed
Collaborator
|
Honestly, I am not really sure of the implications of this PR. I would need to discuss this with @pabzm when he is back... |
Collaborator
Author
any update? |
Collaborator
|
@pabzm can you pleaee have a look at the proposed implementation? Maybe lets have a call about this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #7686
This would be my idea how this can be implemented, if other ways of doing something similar are preferred just close this