Skip to content

aio-interface: handle SSH key authorization error explicitly in remote backup setup#7997

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/handle-ssh-key-error-backup
Open

aio-interface: handle SSH key authorization error explicitly in remote backup setup#7997
Copilot wants to merge 2 commits into
mainfrom
copilot/handle-ssh-key-error-backup

Conversation

Copilot AI commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Comment thread Containers/borgbackup/backupscript.sh Outdated
Comment thread Containers/borgbackup/backupscript.sh
@szaimen szaimen changed the title Handle SSH key authorization error explicitly in remote backup setup aio-interface: handle SSH key authorization error explicitly in remote backup setup Apr 25, 2026
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Apr 25, 2026
@szaimen szaimen force-pushed the copilot/handle-ssh-key-error-backup branch from 22c4b75 to 0cdc06d Compare April 25, 2026 13:32
@szaimen szaimen added this to the next milestone Apr 25, 2026
@szaimen szaimen marked this pull request as ready for review April 25, 2026 13:32
Comment thread php/templates/containers.twig Outdated
@szaimen szaimen force-pushed the copilot/handle-ssh-key-error-backup branch from f9d4d40 to 7263da2 Compare April 25, 2026 13:38
Comment thread php/templates/containers.twig Outdated
Comment thread php/templates/containers.twig Outdated
Comment thread php/templates/containers.twig Outdated
Comment thread php/templates/containers.twig Outdated
Comment thread php/templates/containers.twig Outdated
@szaimen szaimen modified the milestones: v13.0.4, next May 15, 2026
@szaimen szaimen force-pushed the copilot/handle-ssh-key-error-backup branch from 073fab9 to 69fe038 Compare May 21, 2026 10:19
@szaimen szaimen modified the milestones: v13.1.0, next May 22, 2026

@pabzm pabzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the code this looks solid. I didn't test it though since it hasn't been tested at all.

I'm wondering where the selection of error codes 80 and 81 as being SSH-related comes from.

borgbackup.readthedocs.io/en/stable/internals/frontends.html#msgid only says they would represent "ConnectionClosed" and "ConnectionClosedWithHint", which to me sounds like it could be caused by anything network related.

Also there's code 87, "ConnectionBrokenWithHint", which might be worthwhile to consider?

Comment thread Containers/borgbackup/backupscript.sh Outdated
Comment thread php/templates/containers.twig
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 9, 2026
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 18, 2026
@szaimen szaimen requested a review from pabzm June 18, 2026 07:40
Copilot AI and others added 2 commits June 18, 2026 13:39
…e backup setup

Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the copilot/handle-ssh-key-error-backup branch from 4ffc4a9 to 87973d7 Compare June 18, 2026 11:39
@szaimen szaimen modified the milestones: v13.3.0, next Jun 24, 2026
@szaimen szaimen modified the milestones: v13.3.1, next Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants