Skip to content

feat: enforce read-only root filesystem and non-root user for remaining containers#8008

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/set-containers-read-only-rootfs
Draft

feat: enforce read-only root filesystem and non-root user for remaining containers#8008
Copilot wants to merge 3 commits into
mainfrom
copilot/set-containers-read-only-rootfs

Conversation

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI requested a review from szaimen April 27, 2026 08:43
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 27, 2026
@szaimen szaimen marked this pull request as ready for review April 27, 2026 08:44
Comment thread php/containers.json
"collabora"
],
"shm_size": 268435456,
"read_only": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While desirable, I believe it will break commands like coolconfig generate-proof-key that can be used to fix some warnings with the container (see this for example).

Comment thread php/containers.json
"documentation": "https://github.com/nextcloud/all-in-one/discussions/1358",
"display_name": "Nextcloud Office",
"image": "ghcr.io/nextcloud-releases/aio-collabora",
"user": "1001",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed? USER 1001 is already specified in the Collabora Dockerfile

@szaimen szaimen modified the milestones: v13.0.0, next Apr 30, 2026
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 30, 2026
@szaimen szaimen modified the milestones: v13.0.1, next May 4, 2026
@szaimen szaimen modified the milestones: v13.0.2, next May 6, 2026
@szaimen szaimen removed this from the v13.0.3 milestone May 7, 2026
@szaimen szaimen added this to the next milestone May 7, 2026
@szaimen szaimen modified the milestones: v13.0.4, next May 15, 2026
@szaimen szaimen modified the milestones: v13.1.0, next May 22, 2026
@szaimen szaimen modified the milestones: v13.2.0, next Jun 4, 2026
@szaimen szaimen modified the milestones: v13.2.1, next Jun 8, 2026
@szaimen szaimen marked this pull request as draft June 9, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants