aio-interface: Add "Pull new images" button while containers are running#8017
aio-interface: Add "Pull new images" button while containers are running#8017Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/446ad3c6-142d-4e62-adb8-b43a7e548cda Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/446ad3c6-142d-4e62-adb8-b43a7e548cda Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
szaimen
added
3. to review
szaimen
changed the title
pabzm
left a comment
pabzm
left a comment
There was a problem hiding this comment.
I like such a button, but I think we should change the UI so start and update are distinct actions, and add update & stop & start as a shortcut. That way people could still stop and start their containers without having to wait for image pulling, even if updated containers are available. The current solution feels very much like Windows forcing OS updates on shutdown/reboot often in the wrong moment.
Having the old logic side by side with another update-button feels cluttered to me.
szaimen
changed the title
| <form method="POST" action="api/docker/pull-images" target="overlay-log"> | ||
| <input type="hidden" name="{{csrf.keys.name}}" value="{{csrf.name}}"> | ||
| <input type="hidden" name="{{csrf.keys.value}}" value="{{csrf.value}}"> | ||
| <input type="submit" value="Pull new images" /> |
There was a problem hiding this comment.
I remember the problem now: The problem is that it will show the button even if the new container images where already pulled. So we would need to add some additional logic that checks this to hide the button in that case...
There was a problem hiding this comment.
Additionally this block of html should probably also be visible when a mastercontainer udpate is available...
szaimen
added
2. developing
When container updates are available, users had to stop all running containers before they could fetch new images. This adds a one-click way to pre-pull updated images in the background without interrupting the live instance.