Run playwright tests via compose setup, locally and in CI#8247
Open
pabzm wants to merge 7 commits into
Open
Conversation
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
They now are running via a docker compose setup, which can be executed via ./php/tests/run.sh locally, and also gets called from the github workflow. Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
pabzm
force-pushed
the
playwright-compose
branch
from
a0cfaae to
07bd5d5
Compare
Member
Author
|
Rebased to resolve conflicts |
Collaborator
|
Playwright seems to fail unfortunately :/ |
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Member
Author
|
@szaimen It works now, please have another look |
szaimen
added
3. to review
49 tasks
Collaborator
Member
Author
|
I'd be happy to not postpone it too long, since I already had to resolve conflicts twice. but for desec it's ok. |
Collaborator
All right! Will try to review it after merging desec. Thanks for all your effort! |
Collaborator
|
This conflicts now after #7995 unfortunately but I can finally review it after another rebase :) |
szaimen
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playwright tests now are running via a docker compose setup, which can be executed via ./php/tests/run.sh locally, and also gets called from the github workflow.