ship harp also for manual-install and helm#8370
Draft
szaimen wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/ship-harp-manual-install
branch
from
9ea0798 to
c40cb1c
Compare
szaimen
commented
Jun 24, 2026
| - NET_RAW | ||
|
|
||
| nextcloud-aio-harp: | ||
| image: ghcr.io/nextcloud/nextcloud-appapi-harp:latest |
Collaborator
Author
There was a problem hiding this comment.
todo: needs actual release tags for later usage in helm chart. so need to build the image in our repo as well.
szaimen
commented
Jun 24, 2026
| - HP_FRP_DISABLE_TLS=true | ||
| - TZ=${TIMEZONE} | ||
| volumes: | ||
| - ${WATCHTOWER_DOCKER_SOCKET_PATH}:/var/run/docker.sock:ro |
Collaborator
Author
There was a problem hiding this comment.
watchtower socket path needs to be removed for the helm chart build.
21 tasks
When harp syncs over from the manual-install to the helm chart it needs the Kubernetes backend (HP_K8S_*) instead of the docker backend. The update-helm script now injects these env vars into the harp deployment, templated to values.yaml, and the chart readme documents them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
…liases docs - Remove HARP_K8S_BEARER_TOKEN_FILE: HaRP already defaults it to the in-cluster service account token path, so templating it added nothing. - Add HARP_SERVICE_ACCOUNT_NAME so the harp pod can run under a service account the user grants the required RBAC to, and document the setup. - Correct the HARP_K8S_HOST_ALIASES docs: it is a comma-separated list of hostname:ip pairs, not JSON. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
changed the title
szaimen
commented
Jun 24, 2026
| TALK_INTERNAL_SECRET= # TODO! This needs to be a unique and good password! | ||
| TIMEZONE=Europe/Berlin # TODO! This is the timezone that your containers will use. | ||
| TURN_SECRET= # TODO! This needs to be a unique and good password! | ||
| WATCHTOWER_DOCKER_SOCKET_PATH= # TODO! This needs to be a unique and good password! |
Collaborator
Author
There was a problem hiding this comment.
needs to be removed for the helm chart build
Collaborator
Author
There was a problem hiding this comment.
Also add a default value here for manual-install
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.