refactor(thumbnails): simplify doResizedImageInBackground logic

[alperozturk96]

• Tests written, or not not needed

Changes

• Consolidates preview endpoint generation instead of using hard-coded String.
• Adds read timeout to preview endpoint requests
• Uses try-with-resources for safer InputStream handling
• Improves logging for easier debugging
• Introduces early returns to reduce nesting and simplify control flow

Note

After these changes, I didn't come across the following exception:

ThumbnailsCacheManager  com.nextcloud.client  D  The server 10.0.2.2 failed to respond
org.apache.commons.httpclient.NoHttpResponseException: The server 10.0.2.2 failed to respond
    at org.apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1976)
    at org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
    at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
    at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
    at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
    at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
    at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
    at com.owncloud.android.lib.common.OwnCloudClient.executeMethod(OwnCloudClient.java:192)
    at com.owncloud.android.datamodel.ThumbnailsCacheManager.doResizedImageInBackground(ThumbnailsCacheManager.java:1440)
    at com.owncloud.android.datamodel.ThumbnailsCacheManager.-$$Nest$smdoResizedImageInBackground(Unknown Source:0)
    at com.owncloud.android.datamodel.ThumbnailsCacheManager$GalleryImageGenerationTask.getThumbnailFromServerAndAddToCache(ThumbnailsCacheManager.java:360)
    at com.owncloud.android.datamodel.ThumbnailsCacheManager$GalleryImageGenerationTask.doInBackground(ThumbnailsCacheManager.java:347)
    at com.owncloud.android.datamodel.ThumbnailsCacheManager$GalleryImageGenerationTask.doInBackground(ThumbnailsCacheManager.java:298)
    at android.os.AsyncTask$3.call(AsyncTask.java:396)
    at java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1154)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:652)
    at java.lang.Thread.run(Thread.java:1563)

[github-actions]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15974-Unit-test-08-02

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15974.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	42	42
Correctness	73	73
Dodgy code	272	272
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	498	498