Skip to content

Conversation

@GVodyanov
Copy link
Contributor

Fixes the following bug:

  • have a talk room
  • add this talk room to an event, and also an internal user that is not in the room yet, user confirms event participation
  • expected: user gets automatically added to the room
  • what happened: user not in the room, had to add him by hand

The issue was the / becoming encoded as a %2F

@GVodyanov GVodyanov self-assigned this Nov 30, 2025
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/services/talkService.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@SebastianKrupinski
Copy link
Contributor

If the issue was the / getting encoded, did you check if the other paths are okay? Like "room/${token}/participants"??

@GVodyanov
Copy link
Contributor Author

If the issue was the / getting encoded, did you check if the other paths are okay? Like "room/${token}/participants"??

Where is that being used? @SebastianKrupinski

@SebastianKrupinski
Copy link
Contributor

If the issue was the / getting encoded, did you check if the other paths are okay? Like "room/${token}/participants"??

Where is that being used? @SebastianKrupinski

During event create or update, in the talkService, first we create a room then we update the participants on save, but first we pull the existing participants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants