Skip to content

feat: add Nextcloud file tree tool#196

Merged
kyteinsky merged 3 commits into
mainfrom
fix/use-nc-py-api-files-methods
Jun 24, 2026
Merged

feat: add Nextcloud file tree tool#196
kyteinsky merged 3 commits into
mainfrom
fix/use-nc-py-api-files-methods

Conversation

@kyteinsky

Copy link
Copy Markdown
Contributor

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kyteinsky kyteinsky requested review from janepie and marcelklehr June 19, 2026 13:06
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
@kyteinsky kyteinsky force-pushed the fix/use-nc-py-api-files-methods branch from b575267 to 8cdf4bf Compare June 19, 2026 13:07
Comment thread ex_app/lib/all_tools/files.py
Signed-off-by: kyteinsky <kyteinsky@gmail.com>

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

Comment thread ex_app/lib/all_tools/files.py Outdated
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky kyteinsky requested a review from marcelklehr June 23, 2026 08:55
return {
'path': fsnode.user_path,
'file_id': fsnode.info.fileid,
'etag': fsnode.etag.replace('"', '').replace("'", ''),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not manipulate the etag. If those quotes are not wanted, it's a bug in server IMHO

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's just the webdav api. All the etags in the oc_filecache table are without double quotes.
Maybe it's fine to do this, or just remove the quotes from the front and back.
Created an issue here to discuss the approach in nc_py_api: cloud-py-api/nc_py_api#448

@marcelklehr

Copy link
Copy Markdown
Member

I guess CI times out before llm2 is done processing all our tools :(

@kyteinsky

Copy link
Copy Markdown
Contributor Author

Does not look like a CI timeout, it can run for 3-4 hours I think.
it's context agent's 30 min timeout for a task proc task. Maybe that could be made configurable so we can tweak it for the CI:

TIMEOUT: int = 60 * 30 # 30 minutes

@marcelklehr

marcelklehr commented Jun 24, 2026

Copy link
Copy Markdown
Member

Mh, I'm thinking the tool proliferation is a real issue because we bleed tokens and it slows down chat interaction

@kyteinsky

Copy link
Copy Markdown
Contributor Author

let's discuss that in a separate issue/PR.

@kyteinsky kyteinsky changed the title fix: use nc_py_api to get the Nextcloud file tree feat: add Nextcloud file tree tool Jun 24, 2026
@kyteinsky kyteinsky merged commit 8101881 into main Jun 24, 2026
2 of 6 checks passed
@kyteinsky kyteinsky deleted the fix/use-nc-py-api-files-methods branch June 24, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants