refactor: split oauth2 settings form#1034
Draft
saw-jan wants to merge 8 commits into
Draft
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
refactor/separate-oauth2-settings
branch
from
df1e73c to
4e33d45
Compare
saw-jan
force-pushed
the
refactor/separate-oauth2-settings
branch
from
b79fc23 to
d4d9ff1
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
refactor/separate-oauth2-settings
branch
from
d4d9ff1 to
c859819
Compare
PHP Code CoverageCoverage after merging refactor/separate-oauth2-settings into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+72
to
+76
| afterEach(() => { | ||
| jest.clearAllMocks() | ||
| saveAdminConfig.mockRestore() | ||
| createNextcloudOAuthClient.mockRestore() | ||
| }) |
Comment on lines
+152
to
+158
| import FieldValue from './FieldValue.vue' | ||
| import FormHeading from './FormHeading.vue' | ||
| import TextInput from './TextInput.vue' | ||
| import { F_MODES, ADMIN_SETTINGS_FORM, AUTH_METHOD } from '../../utils.js' | ||
| import { saveAdminConfig, createNextcloudOAuthClient } from '../../api/settings.js' | ||
| import { messages, messagesFmt } from '../../constants/messages.js' | ||
|
|
Comment on lines
+189
to
+195
| nextcloudFormId: ADMIN_SETTINGS_FORM.nextcloudOauth.id, | ||
| openprojectFormOrder: ADMIN_SETTINGS_FORM.openprojectOauth.order.toString(), | ||
| nextcloudFormOrder: ADMIN_SETTINGS_FORM.nextcloudOauth.order.toString(), | ||
| messages, | ||
| messagesFmt, | ||
| loading: false, | ||
| openprojectTokenRevokeStatus: null, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile