Skip to content

fix(autocomplete): respect privacy settings for sharing#12715

Open
hamza221 wants to merge 2 commits intomainfrom
fix/respect-sharing-enumeration
Open

fix(autocomplete): respect privacy settings for sharing#12715
hamza221 wants to merge 2 commits intomainfrom
fix/respect-sharing-enumeration

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented Apr 13, 2026

How to test:

  1. Admin settings -> sharing -> Privacy settings for sharing
  2. edit the settings and make sure that both :
  • Adress autocompletion in composer
  • @ the mention shortcut in composer

respect them

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Comment thread lib/Service/ContactsIntegration.php Outdated
Comment thread tests/Unit/Service/Phishing/ContactCheckTest.php Outdated
Comment thread tests/Unit/Service/PhishingDetection/ContactCheckTest.php Outdated
Comment thread tests/Unit/Service/ContactsIntegrationTest.php Outdated
@hamza221
Copy link
Copy Markdown
Contributor Author

@ChristophWurst I've been actually wondering if we want to always allow full sab access to phishing detection check? maybe without exposing the actual contact ?

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 requested a review from ChristophWurst April 15, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants