-
Notifications
You must be signed in to change notification settings - Fork 316
chore(github): try to have productive copilot reviews #12780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <!-- | ||
| - SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| - SPDX-License-Identifier: AGPL-3.0-or-later | ||
| --> | ||
| # Copilot Code Review Instructions | ||
|
|
||
| ## Scope | ||
| Only review for the following: | ||
| - **Bugs** | ||
| - **Security**: Injection vulnerabilities (SQL, command, XSS), hardcoded | ||
| secrets or credentials, insecure deserialization, broken auth, | ||
| path traversal, unsafe use of eval or dynamic code execution. | ||
|
|
||
| ## Strict exclusions — do not comment on these | ||
| - Code style, formatting, or whitespace | ||
| - Naming conventions (variables, functions, classes, files) | ||
| - Suggestions to refactor or restructure working code | ||
| - Performance micro-optimizations unless they cause a measurable performance regression or issue | ||
| - Alternative ways to write functionally equivalent code | ||
|
|
||
| ## If no bugs or security issues are found | ||
| Leave a short positive review. Example: | ||
| > "No bugs or security issues found. Looks good to me." | ||
|
|
||
| ## Review format | ||
| Do not include a summary or overview of the changes at the start of the review. | ||
| Go directly to findings, or if there are none, leave only the approval line. | ||
|
|
||
| ## Comment format (when issues are found) | ||
| For each issue, state: | ||
| 1. **Type**: Bug or Security | ||
| 2. **Severity**: Critical / High / Medium | ||
| 3. **Problem**: What is wrong and why it matters | ||
| 4. **Suggestion**: A concrete fix, not a vague recommendation | ||
|
|
||
| Do not leave comments that don't fit this format. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave that to us humans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can see how it goes and adjust the doc. This is just a start