feat(config): add GOCLAW_CRON_JOB_TIMEOUT env var override#1114
Open
nguyennguyenit wants to merge 1 commit intodevfrom
Open
feat(config): add GOCLAW_CRON_JOB_TIMEOUT env var override#1114nguyennguyenit wants to merge 1 commit intodevfrom
nguyennguyenit wants to merge 1 commit intodevfrom
Conversation
Closes #1098. Aligns with existing GOCLAW_* env-var convention so deployments can override cron.job_timeout without modifying config files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOCLAW_CRON_JOB_TIMEOUTenv var to overridecron.job_timeoutfrom config file.GOCLAW_*env var convention.Closes #1098.
Test plan
go build ./...go test ./internal/config/...GOCLAW_CRON_JOB_TIMEOUT=1h ./goclawoverrides default 10m at runtime.