Report actual missing filename for index paths#1014
Open
huddlej wants to merge 1 commit into
Open
Conversation
Fixes a confusing error message produced by augur index when the output directory for the sequence index does not exist but the error message says the sequences file is missing. The fix is to use the actual filename associated with the `FileNotFoundError` to report the "missing" file, instead of assuming that the missing file is the input. Adds a functional test to capture this expected behavior.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 59.36% 59.36%
=======================================
Files 52 52
Lines 6271 6271
Branches 1579 1579
=======================================
Hits 3723 3723
Misses 2285 2285
Partials 263 263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
victorlin
approved these changes
Aug 9, 2022
Member
|
jameshadfield
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes a confusing error message produced by augur index when the output directory for the sequence index does not exist but the error message says the sequences file is missing. The fix is to use the actual filename associated with the
FileNotFoundErrorto report the "missing" file, instead of assuming that the missing file is the input.Testing