Clade definition inheritance#1836
Draft
jameshadfield wants to merge 3 commits into
Draft
Conversation
If the argument isn't provided we would get a traceback (see below), so
make it required
```
Traceback (most recent call last):
File "/Users/naboo/github/nextstrain/augur/augur/__init__.py", line 70, in run
return args.__command__.run(args)
File "/Users/naboo/github/nextstrain/augur/augur/clades.py", line 385, in run
out_name = get_json_name(args)
File "/Users/naboo/github/nextstrain/augur/augur/utils.py", line 43, in get_json_name
raise ValueError("Please specify a name for the JSON file containing the results.")
ValueError: Please specify a name for the JSON file containing the results.
````
See notes in added `inheritance-clades.tsv`
Example implementation to continue discussion in <#1837>
jameshadfield
force-pushed
the
james/clade-inheritance
branch
from
4351d0e to
81684d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1837