Add 'sharing.screenshot' to config schema#1999
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1999 +/- ##
=======================================
Coverage 72.91% 72.92%
=======================================
Files 85 85
Lines 10711 10714 +3
Branches 2096 2096
=======================================
+ Hits 7810 7813 +3
Misses 2535 2535
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I forgot to add this property in #1993
jameshadfield
force-pushed
the
james/schema-fix
branch
from
72e3a21 to
5782f43
Compare
This was highlighted by newly failing (stochastic?) CI runs, e.g. <https://github.com/nextstrain/augur/actions/runs/26004521274/job/76434263607> export_v2.py:docstring of augur.export_v2.transfer_directly_from_config:: WARNING: py:class reference target not found: string [ref.class] CI passed on the PR which introduced this code <#1993> I presume the new failures are due to newer versions of Sphinx/numpydoc being stricter about resolving type references in docstrings.
Member
Author
|
CI failure is due to rabies ingest, which has been consistently failing in various PRs this morning. Merging. |
victorlin
reviewed
May 19, 2026
| config : dict | ||
| config JSON with an expected | ||
| key : string | ||
| key : str |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to add this property in #1993