useModelData: memoize the config object#32
Merged
jameshadfield merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
Memoize the `config` object to avoid cases of infinite fetches due `useEffect` doing a shallow comparison of the object. Prompted by discussion on Slack <https://bedfordlab.slack.com/archives/C03KWDET9/p1766441215142239>
from the JS file (one day we'll hopefully use TS!)
jameshadfield
force-pushed
the
memo-config
branch
from
f7c5f44 to
c1dfefa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Memoize the
configobject to avoid cases of infinite fetches dueuseEffectdoing a shallow comparison of the object.Prompted by discussion on Slack
Related issue
Related to nextstrain/forecasts-flu#26
Checklist