FIX: dot product issue causing high RAM usage in reconst_fw_noddi#366
Merged
arnaudbore merged 2 commits intoMay 25, 2026
Merged
Conversation
gagnonanthony
changed the title
reconstruction_fw_noddireconst_fw_noddi
Member
Author
|
When you are ready @AlexVCaron and @arnaudbore, it should be good to review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug category
Describe the bug
Previous implementation used the
.combineoperator to mix the priors together. However, when supplying per-subject priors for a lot of subjects, this causes nextflow to create an exponential number of tuples, which bloats up the RAM usage (I made it up to 64GB, which does not make any sense). This PR fixes this while retaining all functionalities.Tested on 300 subjects and 526 subjects, everything runs smoothly!
Steps to reproduce the bug
Run the noddi subworkflow across many subjects while supplying per-subject priors.