pkgconfig: add boost include headers path#27
Conversation
Summary of ChangesHello @peckato1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a common build issue where projects linking against nghttp2-asio would encounter compilation errors due to missing Boost include paths in the generated pkg-config file. By integrating Boost's include directories into the pkg-config Cflags, this change ensures that dependent projects can correctly locate Boost headers, regardless of its installation location. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where the Boost include path was not added to the pkg-config file for nghttp2-asio when Boost is installed in a non-standard location. While the intention is correct, the current implementation does not properly handle cases where Boost_INCLUDE_DIRS contains multiple paths, which would lead to incorrect Cflags in the generated pkg-config file. My review provides suggestions to create a more robust solution by iterating over all possible Boost include directories and formatting them correctly for the Cflags property, ensuring the fix works in all scenarios.
If nghttp2-asio was compiled with boost in a non-standard location, the generated pkg-config file did not include the boost include path, which could lead to compilation errors for projects depending on nghttp2-asio.
140dde5 to
7f9be4c
Compare
If nghttp2-asio was compiled with boost in a non-standard location, the generated pkg-config file did not include the boost include path, which could lead to compilation errors for projects depending on nghttp2-asio.