Skip to content

pkgconfig: add boost include headers path#27

Open
peckato1 wants to merge 1 commit into
nghttp2:mainfrom
peckato1:pkgconfig-boost
Open

pkgconfig: add boost include headers path#27
peckato1 wants to merge 1 commit into
nghttp2:mainfrom
peckato1:pkgconfig-boost

Conversation

@peckato1
Copy link
Copy Markdown

@peckato1 peckato1 commented Dec 2, 2025

If nghttp2-asio was compiled with boost in a non-standard location, the generated pkg-config file did not include the boost include path, which could lead to compilation errors for projects depending on nghttp2-asio.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @peckato1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a common build issue where projects linking against nghttp2-asio would encounter compilation errors due to missing Boost include paths in the generated pkg-config file. By integrating Boost's include directories into the pkg-config Cflags, this change ensures that dependent projects can correctly locate Boost headers, regardless of its installation location.

Highlights

  • pkg-config Generation: The pkg-config file generation logic has been updated to correctly include Boost header paths, addressing issues where projects depending on nghttp2-asio would fail to compile if Boost was in a non-standard location.
  • Build System Integration: A new CMake variable boostincludedir is introduced to capture the Boost_INCLUDE_DIRS and propagate it into the generated libnghttp2_asio.pc.in file's Cflags.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where the Boost include path was not added to the pkg-config file for nghttp2-asio when Boost is installed in a non-standard location. While the intention is correct, the current implementation does not properly handle cases where Boost_INCLUDE_DIRS contains multiple paths, which would lead to incorrect Cflags in the generated pkg-config file. My review provides suggestions to create a more robust solution by iterating over all possible Boost include directories and formatting them correctly for the Cflags property, ensuring the fix works in all scenarios.

Comment thread CMakeLists.txt Outdated
Comment thread lib/libnghttp2_asio.pc.in Outdated
If nghttp2-asio was compiled with boost in a non-standard location,
the generated pkg-config file did not include the boost include
path, which could lead to compilation errors for projects depending
on nghttp2-asio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant