Fix exception in server#9
Open
m8mble wants to merge 1 commit intonghttp2:mainfrom
Open
Conversation
It can happen that a connection handler calls writefun when the connection is already destroyed. This causes bad_weak_ptr exceptions thrown from the server. Fix this issue by skipping the respective do_write invocations.
m8mble
force-pushed
the
fix-exception
branch
from
4a67448 to
b4745aa
Compare
|
Thanks! We encountered the same problem with wild |
jktjkt
added a commit
to CESNET/rousette
that referenced
this pull request
Sep 23, 2025
The latest upstream version does not build on Boost 1.87, and there's a nasty crash in the destructor which led to a nice little heap of hair on our desks. It's time to fork that thing. Link: nghttp2/nghttp2-asio#9 Link: nghttp2/nghttp2-asio#25 Change-Id: Iec9619ce45e7e76f0781d39966d0b6c7cc6fa778
troglobit
pushed a commit
to kernelkit/rousette
that referenced
this pull request
Mar 19, 2026
The latest upstream version does not build on Boost 1.87, and there's a nasty crash in the destructor which led to a nice little heap of hair on our desks. It's time to fork that thing. Link: nghttp2/nghttp2-asio#9 Link: nghttp2/nghttp2-asio#25 Change-Id: Iec9619ce45e7e76f0781d39966d0b6c7cc6fa778 Signed-off-by: Mattias Walström <lazzer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen that a connection handler calls writefun when the connection is already destroyed. This causes bad_weak_ptr exceptions thrown from the server.
Fix this issue by skipping the respective do_write invocations.
Problem encountered in a real-world server.