Open
Conversation
A check that NGINX accepts malformed HTTP/2 or HTTP/3 requests should be specific to such malformed requests, not hidden in general tests for HTTP/2 and HTTP/3 headers.
Do not use a regular expression that matches CR.
Lots of code used a bare LF in the HTTP protocol, but that is wrong: RFC9112 is very clear that CRLF is the HTTP line terminator. Most of the changes are just replacing \n with \r\n or adding missing \r in heredocs, but it is also necessary to update byte counts to include the extra bytes.
DemiMarie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Only send well-formed messages to NGINX, unless a test is about non-conforming messages being rejected.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).