Fix #3725: DbBatchBatcher empty batch execution bug #3726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3725
Description
DbBatchBatcherthrowsInvalidOperationExceptionwhen attempting to execute an empty batch, whileGenericBatchingBatcherandSqlClientBatchingBatcherhandle this scenario correctly.Root Cause
DbBatchBatcher.DoExecuteBatch()andDoExecuteBatchAsync()lack empty batch validation. WhenExecuteBatch()is called with an empty batch (
_currentBatch.BatchCommands.Count == 0), the code attempts to execute aDbBatchwith no commands, causing:
System.InvalidOperationException: ExecuteNonQuery: CommandText property has not been initialized
Changes
Added empty batch check at the beginning of both methods, matching the pattern used in
GenericBatchingBatcher:Modified:
Added: