Skip to content

github: Enable GitHub Actions static analysis with zizmor#1310

Open
bkeryan wants to merge 6 commits into
mainfrom
users/bkeryan/zizmor
Open

github: Enable GitHub Actions static analysis with zizmor#1310
bkeryan wants to merge 6 commits into
mainfrom
users/bkeryan/zizmor

Conversation

@bkeryan
Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan commented Jun 6, 2026

What does this Pull Request accomplish?

Enable static analysis with Zizmor and address all of the errors that it reports.

Disable setup-poetry caching in publish.yml.

Update sync_github_issues_to_azdo.yml to use a case function instead of a shell script.

Why should this Pull Request be merged?

Follow GitHub Actions security best practices.

What testing has been done?

PR build

@bkeryan bkeryan requested review from csjall and dixonjoel as code owners June 6, 2026 00:18
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

git archive -o dist/${EXAMPLE_ARCHIVE}.zip ${GITHUB_REF}:examples/
git archive -o dist/${EXAMPLE_ARCHIVE}.tar.gz --prefix ${EXAMPLE_ARCHIVE}/ ${GITHUB_REF}:examples/
- name: Upload release assets
- name: Upload release assets # zizmor: ignore[superfluous-actions]
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.zizmor.sh/audits/#superfluous-actions

They suggest replacing this action with gh CLI, but I don't want to rewrite this part of the publish workflow right now.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

Test Results

    52 files  ±0      52 suites  ±0   1h 17m 36s ⏱️ -4s
   689 tests ±0     689 ✅ ±0      0 💤 ±0  0 ❌ ±0 
20 700 runs  ±0  19 644 ✅ ±0  1 056 💤 ±0  0 ❌ ±0 

Results for commit 2d50e54. ± Comparison against base commit fdf1cc5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants