Force LF checkout of goldens so tests pass on Windows clones - #3
Open
MrTig-afk wants to merge 1 commit into
Open
Force LF checkout of goldens so tests pass on Windows clones#3MrTig-afk wants to merge 1 commit into
MrTig-afk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh clone on Windows with the default
core.autocrlf=truefails 59 of 157 tests: git converts the committed golden.mjmlfiles to CRLF on checkout, the renderer emits LF, and every byte comparison fails.Fix: a four-line
.gitattributespinning.mjml,.md, and.jsonto LF. Repository blobs are already LF throughout, so nothing renormalizes.Verification: fresh Windows clone before the change fails 59/157; with the change, 157/157 pass.