Repository navigation
etag: fix typo & etag save - #40
Merged
Merged
Conversation
Fix typo in etag comparison logic. Save etag after the actual json is downloaded successfully to avoid cache corruption in case download fails. Signed-off-by: gegham1 <geghamayvazyan9@gmail.com>
Contributor
Author
|
I also added some tests to check my fix, let me know if you want me to commit them as well. |
RafaelGSS
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etag: fix typo & etag save
Fix typo in etag comparison logic.
Save etag after the actual json is downloaded successfully
to avoid cache corruption in case download fails.