quic: correct http3 callback and fix revealed errs#64289
Merged
Conversation
The http3 application had misinterpreted some of nghttp3 callbacks regarding stopSending and ResetStream. Actually, these callbacks asks the application to do the action and not informs about an event from the peer. The fixes lead to some failures of the automated tests, uncovering some problems: First headers, and pendingTrailers were reset, when the internal object went away, though the test wanted to read them. Second, during a graceful session shutdown, the implemented did not waited for all stream to be removed, but only one. Fixes: nodejs#63657 Signed-off-by: Marten Richter <marten.richter@freenet.de>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
Author
jasnell
approved these changes
Jul 4, 2026
Qard
approved these changes
Jul 5, 2026
jasnell
approved these changes
Jul 6, 2026
pimterry
approved these changes
Jul 7, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
pimterry
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 799e910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The http3 application had misinterpreted some of
nghttp3 callbacks regarding stopSending
and ResetStream.
Actually, these callbacks asks the application
to do the action and not informs about an event
from the peer.
The fixes lead to some failures of the automated
tests, uncovering some problems:
First headers, and pendingTrailers were reset,
when the internal object went away,
though the test wanted to read them.
Second, during a graceful session shutdown,
the implemented did not waited for all stream
to be removed, but only one.
Fixes: #63657