perf_hooks: add PerformanceEntry id and navigationId - #64898
Open
HoonDongKang wants to merge 1 commit into
Open
Conversation
Add the PerformanceEntry id and navigationId attributes required by the Performance Timeline IDL. Entries get an id when queued, following the Performance Timeline queueing algorithm. Update the performance-timeline WPT status now that idlharness.any.js passes for these attributes. Refs: https://w3c.github.io/performance-timeline/#performanceentry Refs: https://w3c.github.io/performance-timeline/#queue-a-performanceentry Refs: https://w3c.github.io/performance-timeline/#generate-a-performance-entry-id Signed-off-by: HoonDongKang <d159123@naver.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64898 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 746 746
Lines 242846 242881 +35
Branches 45771 45772 +1
==========================================
+ Hits 218909 218931 +22
- Misses 15439 15441 +2
- Partials 8498 8509 +11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
PerformanceEntry.prototype.idandPerformanceEntry.prototype.navigationIdto match the Performance Timeline IDL.Entries are assigned an id when they are queued, following the Performance Timeline
Queue a PerformanceEntryalgorithm.navigationIdis initialized to0; Node.js does not currently track a Document-associated most recent navigation forperf_hooksentries.This also updates the
performance-timelineWPT status now thatidlharness.any.jspasses for these attributes.Refs:
Tests