Skip to content

src: avoid task runner crash on inaccessible bin paths - #64905

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner2
Open

src: avoid task runner crash on inaccessible bin paths#64905
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner2

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Use the error_code overload of std::filesystem::is_directory() when probing node_modules/.bin, allowing package.json lookup to continue when the directory cannot be accessed.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (a4aa3c0) to head (38bb89c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64905   +/-   ##
=======================================
  Coverage   90.28%   90.29%           
=======================================
  Files         760      760           
  Lines      247061   247062    +1     
  Branches    46592    46587    -5     
=======================================
+ Hits       223058   223081   +23     
+ Misses      15491    15459   -32     
- Partials     8512     8522   +10     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.38% <100.00%> (+0.05%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Use the error_code overload of std::filesystem::is_directory() when
probing node_modules/.bin, allowing package.json lookup to continue when
the directory cannot be accessed.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants