Skip to content

src: override inherited task runner environment - #64906

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner3
Open

src: override inherited task runner environment#64906
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner3

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Filter inherited NODE_RUN_SCRIPT_NAME and NODE_RUN_PACKAGE_JSON_PATH before adding the current task values. This prevents duplicate environment entries during nested node --run invocations.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (a4aa3c0) to head (86ee17a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64906      +/-   ##
==========================================
+ Coverage   90.28%   90.30%   +0.01%     
==========================================
  Files         760      760              
  Lines      247061   247065       +4     
  Branches    46592    46586       -6     
==========================================
+ Hits       223058   223108      +50     
+ Misses      15491    15441      -50     
- Partials     8512     8516       +4     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.01% <100.00%> (-0.32%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Filter inherited NODE_RUN_SCRIPT_NAME and NODE_RUN_PACKAGE_JSON_PATH
before adding the current task values. This prevents duplicate
environment entries during nested node --run invocations.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants