src: match cmd.exe case-insensitively in task runner - #64907
Merged
Conversation
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64907 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 760 760
Lines 247061 247061
Branches 46592 46590 -2
==========================================
- Hits 223058 223037 -21
- Misses 15491 15499 +8
- Partials 8512 8525 +13
🚀 New features to boost your workflow:
|
Use a case-insensitive suffix comparison for ComSpec so uppercase and mixed-case CMD.EXE paths use the correct /c invocation. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
avivkeller
approved these changes
Aug 1, 2026
This comment was marked as spam.
This comment was marked as spam.
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
avivkeller
added
the
commit-queue
Collaborator
|
Landed in ab9afa9 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a case-insensitive suffix comparison for ComSpec so uppercase and mixed-case CMD.EXE paths use the correct /c invocation.